Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stacked pings for users with numbers as names #78

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix stacked pings for users with numbers as names #78

merged 1 commit into from
Oct 16, 2024

Conversation

sqyyy-jar
Copy link
Contributor

@sqyyy-jar sqyyy-jar commented Oct 15, 2024 •
edited
Loading

This pull request attempts to fix #72. I tested it locally and it seems to solve the issue. Let me know if you want this to be solved differently.

To explain how it works: it stops replacing tags that are preceded by a < so that tags are not replaced multiple times.

@Phoenix616
Copy link
Contributor

Looks like an adequate solution and I couldn't think of a better approach right now.

@zachbr
Copy link
Owner

zachbr commented Oct 16, 2024

Seems reasonable enough. Thanks for the PR.

@zachbr zachbr merged commit 1b9b753 into zachbr:master Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phoenix616 Phoenix616 Phoenix616 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bot pings people with numbers as names instead of user
3 participants
@sqyyy-jar @Phoenix616 @zachbr